Add std::string constructor to SuffixArray#116
Open
keyansheng wants to merge 2 commits intostevenhalim:masterfrom
Open
Add std::string constructor to SuffixArray#116keyansheng wants to merge 2 commits intostevenhalim:masterfrom
keyansheng wants to merge 2 commits intostevenhalim:masterfrom
Conversation
A const lvalue reference (const string& initialT) allows an rvalue
reference (initialT + "$") to be passed in, which is now "owned" by
SuffixArray and gets destructed after the SuffixArray constructor exits.
By removing const, only an lvalue reference can be passed in, which is
not "owned" by SuffixArray and does not get destructed after the
SuffixArray constructor exits.
Attempting to pass initialT + "$" to the constructor now results in a
compile-time error, which is good since creating a copy is a bad idea
anyway.
Instead, you can initialT.push_back('$') before calling the
constructor, similar to how the original char* constructor works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.