Open
Conversation
| // add an argument to a Fusion cons-list for each parameter type | ||
| template <typename Args, typename ArgStream> | ||
| static inline typename result_type<F>::type apply(F func, ArgStream& astream, | ||
| static inline auto apply(F func, ArgStream& astream, |
Member
There was a problem hiding this comment.
Do we want to use decltype(auto) in cases like this? auto will strip references and top-level cv-qualifiers, which may not be what we want here.
Member
There was a problem hiding this comment.
To match the prior semantics, it should be decltype(auto).
Member
fosterbrereton
left a comment
There was a problem hiding this comment.
One question about auto v. decltype(auto) - I'll let @sean-parent sign off on the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vector.hpp and string_fwd.hpp were deprecated 12 years ago, and cstdint is not very useful. Beside that replace boost::filesystem with std, and other minor de-boost changes