Variant addition: Nucleo-64 L412RB_P

[askuric]

Summary

This PR adds the support for the nucleo l412rb_p variant.
And for the generic family associated with it (L412RBIxP and L412RBTxP)

It is realted to these issues:

• Add board NUCLEO L412RB-P #1350
• [New Variant] NUCLEO-L412RB-P #2663

Which have been merged within this issue:

• [New Variant] request list #722

Validation

• The code has been tested using the CheckVariant example:

The built-in led blinks and this is the serial output:

####
NUM_DIGITAL_PINS = 50
NUM_ANALOG_INPUTS = 13
#####
Checking digital pins...
End check digital pins
#####
Checking analog pins definition...
End check analog pins
#####
Checking IP instances (I2C, UART, SPI)...
End check IP instances (I2C, UART, SPI)

########################################
#### Test PASSED
########################################

• The nucleo has been tested using SimpleFOC library (ADC+PWMs) and everything seems to work well.

Code formatting

I'm happy to adapt it to your requirements if needed.

[fpistm]

Hi @askuric
Thanks the PR. Nice job.
Small comments to fix and ideally would prefers 2 commits one for the generic part and one for the variants.

[askuric]

Hi @fpistm,

Thanks for the comments.
I've just realised that when I apply the changes you suggested the comments disappear as well.

The changes that I've done:

• Updated readme to remove the change of the unrealted board
• Updated the boards.txt to remove the end of file change (missing empty line at the end)

Accepted the changes

• memory ld file: I've used the stock file generated by CubeMX, I did not necessary have a use for the RAM2, that's how CubeMX generated the file. So if you want me to remove it let me know. :D
• TIM7 used but not defined: I've used the nucleo_l433rc_p files as a template for this l412rb_p as they belong to the same family of nucleos-64. As I ran the examples and I did not see any errors I did not catch this issue and the TIM7 stayed.

How did you test the variant?
I've tested it using Arduino IDE, I've changed the files in the arduino board packages and used the checkvariant example link (I've copied it in the arduino sketch and run it on the nucleo board).
Also, I've used SimpleFOC and run a code turning a motor on the nucleo and measuring the currents. Which worked well.

Is there a better way of testing. I'm planning to add two more nucleo-64 variants in the next few days so if you have some suggestions, please let me know :D

[fpistm]

Is there a better way of testing. I'm planning to add two more nucleo-64 variants in the next few days so if you have some suggestions, please let me know :D

No it is a good way to test the variant and its definitnion. As said, it is really strange you didn't see the build issue, maybe an issue in the selected target.

[fpistm]

LGTM

[askuric]

Ok that's interesting. Now I'm having some issues with the build with the latest changes.
When I build and upload the code to the board I get the FAIL.txt file which says:

The application file format is unknown and cannot be parsed and/or processed

I think that my lack of experience is catching up with my initial luck. :D
Let me do some more testing and come back to you.

[fpistm]

The application file format is unknown and cannot be parsed and/or processed

Try to update the STLink firmware using the STM32Cube programmer thanks the "Firmware upgrade" button.

[askuric]

Try to update the STLink firmware using the STM32Cube programmer thanks the "Firmware upgrade" button.

I've tried this and it did not make any difference.
But what did make a difference is to put the Upload method to STM32CubeProgrammer (SWD) and not Mass storage. :D
With the SWD I have no more issues and everything works well.

Is this a red flag or is it normal?

Additionally, I've run some more tests, so far I've tested:

• Timers
• ADC
• SPI
• Pin names (as I'm using Arduino UNO R3 header names)

And everything seems to work as expected.

[fpistm]

If swd works it is linked to the Stlink firmware which provides the mass storage storage.
No link with the binary

[askuric]

So then it's an issue with my setup, not the variant files right?
So the PR is ok?

[fpistm]

Unfortunately, I do not have this board to test anyway from my point of view the PR is ok.