Allow for custom HEAD request URLs#221
Open
leviwilson wants to merge 1 commit intostreamio:masterfrom
Open
Conversation
When using an S3 presigned URL, you cannot obtain a URL for a private object that allows for both a GET and a HEAD request on it. Because of this, you need to: head_url = object.presigned_url(:head) get_url = object.presigned_url(:get) ...independently of each other. This means that you cannot get media information with this gem. To _allow_ for this, I've added an option to pass in a custom head_url: argument to allow for this separation. In this manner, you can now do this: movie = FFMPEG::Movie.new(object.presigned_url(:get), head_url: object.presigned_url(:head)) And obtain your information successfully.
leviwilson
force-pushed
the
custom_head_request
branch
from
c0ce893 to
f02f616
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using an S3 presigned URL, you cannot obtain a URL for a private object that allows
for both a GET and a HEAD request on it.
Because of this, you need to:
...independently of one another.
This means that you cannot get media information with this gem.
To allow for this, I've added an option to pass in a custom head_url: argument to allow
for this separation.
In this manner, you can now do this:
And obtain your information successfully.