Skip to content

feat: Merge additional tags into vpc_endpoint#183

Open
mitch-hamm wants to merge 1 commit intomasterfrom
mh/add-tags-to-gateway
Open

feat: Merge additional tags into vpc_endpoint#183
mitch-hamm wants to merge 1 commit intomasterfrom
mh/add-tags-to-gateway

Conversation

@mitch-hamm
Copy link
Copy Markdown
Contributor

@mitch-hamm mitch-hamm commented Apr 6, 2026

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

When passing additional_tags to the module, it should also be applied to this resource if created

Modifications

Update the passed tags to include merging the additional_tags into the pre-defined StreamNative tags

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    No need to update docs. This just updates passing the additional tags to a missing resource

  • doc

    (If this PR contains doc changes)

@mitch-hamm mitch-hamm requested a review from a team as a code owner April 6, 2026 22:47
@mitch-hamm mitch-hamm self-assigned this Apr 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2026

@mitch-hamm:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Apr 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2026

@mitch-hamm:Thanks for providing doc info!

@github-actions github-actions bot added no-need-doc This pr does not need any document and removed doc-info-missing This pr needs to mark a document option in description labels Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-need-doc This pr does not need any document

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant