-
Notifications
You must be signed in to change notification settings - Fork 497
Add decimal_string coercion for v1 and v2 API fields #1769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jar-stripe
wants to merge
2
commits into
master
Choose a base branch
from
jar/decimal-tier2-python
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,7 @@ | |
| import datetime | ||
| import time | ||
| from collections import OrderedDict | ||
| from decimal import Decimal | ||
| from typing import Any, Dict, Generator, Mapping, Optional, Tuple, Union | ||
|
|
||
|
|
||
|
|
@@ -82,6 +83,38 @@ def _coerce_int64_string(value: Any, *, encode: bool) -> Any: | |
| return value | ||
|
|
||
|
|
||
| def _coerce_decimal_string(value: Any, *, encode: bool) -> Any: | ||
| """ | ||
| Coerce a decimal_string value in either direction. | ||
|
|
||
| encode=True: Decimal/int/float → str (request serialization) | ||
| encode=False: str → Decimal (response hydration) | ||
| """ | ||
| if value is None: | ||
| return None | ||
|
|
||
| if encode: | ||
| if isinstance(value, list): | ||
| return [ | ||
| str(v) | ||
| if isinstance(v, (Decimal, int, float)) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this check is repeated twice. Seems like the list iteration should recurse into |
||
| and not isinstance(v, bool) | ||
| else v | ||
| for v in value | ||
| ] | ||
| if isinstance(value, (Decimal, int, float)) and not isinstance( | ||
| value, bool | ||
| ): | ||
| return str(value) | ||
| return value | ||
| else: | ||
| if isinstance(value, list): | ||
| return [Decimal(v) if isinstance(v, str) else v for v in value] | ||
| if isinstance(value, str): | ||
| return Decimal(value) | ||
| return value | ||
|
|
||
|
|
||
| def _coerce_value(value: Any, schema: _SchemaNode) -> Any: | ||
| """Coerce a single value according to its schema node.""" | ||
| if value is None: | ||
|
|
@@ -90,6 +123,9 @@ def _coerce_value(value: Any, schema: _SchemaNode) -> Any: | |
| if schema == "int64_string": | ||
| return _coerce_int64_string(value, encode=True) | ||
|
|
||
| if schema == "decimal_string": | ||
| return _coerce_decimal_string(value, encode=True) | ||
|
|
||
| if isinstance(schema, dict): | ||
| # Nested object schema | ||
| if isinstance(value, list): | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.