return None for .deleted

stripe/_account.py

@@ -98,6 +98,7 @@ class Account(
     """
 
     OBJECT_NAME: ClassVar[Literal["account"]] = "account"
+    _has_deleted_version = True
 
     class BusinessProfile(StripeObject):
         class AnnualRevenue(StripeObject):

stripe/_apple_pay_domain.py

@@ -29,6 +29,7 @@ class ApplePayDomain(
     ListableAPIResource["ApplePayDomain"],
 ):
     OBJECT_NAME: ClassVar[Literal["apple_pay_domain"]] = "apple_pay_domain"
+    _has_deleted_version = True
     created: int
     """
     Time at which the object was created. Measured in seconds since the Unix epoch.

stripe/_application.py

@@ -7,6 +7,7 @@
 
 class Application(StripeObject):
     OBJECT_NAME: ClassVar[Literal["application"]] = "application"
+    _has_deleted_version = True
     deleted: Optional[Literal[True]]
     """
     Always true for a deleted object

stripe/_bank_account.py

@@ -35,6 +35,7 @@ class BankAccount(
     """
 
     OBJECT_NAME: ClassVar[Literal["bank_account"]] = "bank_account"
+    _has_deleted_version = True
 
     class FutureRequirements(StripeObject):
         class Error(StripeObject):

stripe/_card.py

@@ -26,6 +26,7 @@ class Card(DeletableAPIResource["Card"], UpdateableAPIResource["Card"]):
     """
 
     OBJECT_NAME: ClassVar[Literal["card"]] = "card"
+    _has_deleted_version = True
 
     class Networks(StripeObject):
         preferred: Optional[str]

stripe/_coupon.py

@@ -31,6 +31,7 @@ class Coupon(
     """
 
     OBJECT_NAME: ClassVar[Literal["coupon"]] = "coupon"
+    _has_deleted_version = True
 
     class AppliesTo(StripeObject):
         products: List[str]

stripe/_customer.py

@@ -132,6 +132,7 @@ class Customer(
     """
 
     OBJECT_NAME: ClassVar[Literal["customer"]] = "customer"
+    _has_deleted_version = True
 
     class Address(StripeObject):
         city: Optional[str]

stripe/_discount.py

@@ -20,6 +20,7 @@ class Discount(StripeObject):
     """
 
     OBJECT_NAME: ClassVar[Literal["discount"]] = "discount"
+    _has_deleted_version = True
 
     class Source(StripeObject):
         coupon: Optional[ExpandableField["Coupon"]]

stripe/_invoice.py

@@ -124,6 +124,7 @@ class Invoice(
     """
 
     OBJECT_NAME: ClassVar[Literal["invoice"]] = "invoice"
+    _has_deleted_version = True
 
     class AutomaticTax(StripeObject):
         class Liability(StripeObject):

stripe/_invoice_item.py

@@ -51,6 +51,7 @@ class InvoiceItem(
     """
 
     OBJECT_NAME: ClassVar[Literal["invoiceitem"]] = "invoiceitem"
+    _has_deleted_version = True
 
     class Parent(StripeObject):
         class SubscriptionDetails(StripeObject):

stripe/_person.py

@@ -22,6 +22,7 @@ class Person(UpdateableAPIResource["Person"]):
     """
 
     OBJECT_NAME: ClassVar[Literal["person"]] = "person"
+    _has_deleted_version = True
 
     class AdditionalTosAcceptances(StripeObject):
         class Account(StripeObject):

stripe/_plan.py

@@ -38,6 +38,7 @@ class Plan(
     """
 
     OBJECT_NAME: ClassVar[Literal["plan"]] = "plan"
+    _has_deleted_version = True
 
     class Tier(StripeObject):
         flat_amount: Optional[int]

stripe/_price.py

@@ -45,6 +45,7 @@ class Price(
     """
 
     OBJECT_NAME: ClassVar[Literal["price"]] = "price"
+    _has_deleted_version = True
 
     class CurrencyOptions(StripeObject):
         class CustomUnitAmount(StripeObject):

stripe/_product.py

@@ -67,6 +67,7 @@ class Product(
     """
 
     OBJECT_NAME: ClassVar[Literal["product"]] = "product"
+    _has_deleted_version = True
 
     class MarketingFeature(StripeObject):
         name: Optional[str]

stripe/_product_feature.py

@@ -15,6 +15,7 @@ class ProductFeature(StripeObject):
     """
 
     OBJECT_NAME: ClassVar[Literal["product_feature"]] = "product_feature"
+    _has_deleted_version = True
     deleted: Optional[Literal[True]]
     """
     Always true for a deleted object

stripe/_stripe_object.py

@@ -90,6 +90,8 @@ def default(self, o: Any) -> Any:
 
     _retrieve_params: Mapping[str, Any]
     _previous: Optional[Mapping[str, Any]]
+    # overridden on a per-resource basis in codegen
+    _has_deleted_version = False
 
     def __init__(
         self,
@@ -143,10 +145,8 @@ def last_response(self) -> Optional[StripeResponse]:
         return self._last_response
 
     def update(self, update_dict: Mapping[str, Any]) -> None:
-        for k in update_dict:
-            self._unsaved_values.add(k)
-
-        self._data.update(update_dict)
+        for k, v in update_dict.items():
+            self[k] = v
 
     if not TYPE_CHECKING:
 
@@ -213,6 +213,11 @@ def __getitem__(self, k: str) -> Any:
                     "available on this object are: %s"
                     % (k, k, ", ".join(list(self._data.keys())))
                 )
+            elif k == "deleted" and self._has_deleted_version:
+                # certain objects have a `deleted` property that's None or true.
+                # Because of the way missing property access works, you couldn't write `if customer.deleted` because that was either true or an error.
+                # so to support this check specifically, we return the default value rather than erroring
+                return None
             else:
                 from stripe._invoice import Invoice
 

stripe/_subscription_item.py

@@ -45,6 +45,7 @@ class SubscriptionItem(
     """
 
     OBJECT_NAME: ClassVar[Literal["subscription_item"]] = "subscription_item"
+    _has_deleted_version = True
 
     class BillingThresholds(StripeObject):
         usage_gte: Optional[int]

stripe/_tax_id.py

@@ -33,6 +33,7 @@ class TaxId(
     """
 
     OBJECT_NAME: ClassVar[Literal["tax_id"]] = "tax_id"
+    _has_deleted_version = True
 
     class Owner(StripeObject):
         account: Optional[ExpandableField["Account"]]

stripe/_webhook_endpoint.py

@@ -44,6 +44,7 @@ class WebhookEndpoint(
     """
 
     OBJECT_NAME: ClassVar[Literal["webhook_endpoint"]] = "webhook_endpoint"
+    _has_deleted_version = True
     api_version: Optional[str]
     """
     The API version events are rendered as for this webhook endpoint.

stripe/apps/_secret.py

@@ -30,6 +30,7 @@ class Secret(CreateableAPIResource["Secret"], ListableAPIResource["Secret"]):
     """
 
     OBJECT_NAME: ClassVar[Literal["apps.secret"]] = "apps.secret"
+    _has_deleted_version = True
 
     class Scope(StripeObject):
         type: Literal["account", "user"]

stripe/radar/_value_list.py

@@ -39,6 +39,7 @@ class ValueList(
     """
 
     OBJECT_NAME: ClassVar[Literal["radar.value_list"]] = "radar.value_list"
+    _has_deleted_version = True
     alias: str
     """
     The name of the value list for use in rules.

stripe/radar/_value_list_item.py

@@ -37,6 +37,7 @@ class ValueListItem(
     OBJECT_NAME: ClassVar[Literal["radar.value_list_item"]] = (
         "radar.value_list_item"
     )
+    _has_deleted_version = True
     created: int
     """
     Time at which the object was created. Measured in seconds since the Unix epoch.

stripe/terminal/_configuration.py

@@ -44,6 +44,7 @@ class Configuration(
     OBJECT_NAME: ClassVar[Literal["terminal.configuration"]] = (
         "terminal.configuration"
     )
+    _has_deleted_version = True
 
     class BbposWisepad3(StripeObject):
         splashscreen: Optional[ExpandableField["File"]]

stripe/terminal/_location.py

@@ -39,6 +39,7 @@ class Location(
     """
 
     OBJECT_NAME: ClassVar[Literal["terminal.location"]] = "terminal.location"
+    _has_deleted_version = True
 
     class Address(StripeObject):
         city: Optional[str]

stripe/terminal/_reader.py

@@ -74,6 +74,7 @@ class Reader(
     """
 
     OBJECT_NAME: ClassVar[Literal["terminal.reader"]] = "terminal.reader"
+    _has_deleted_version = True
 
     class Action(StripeObject):
         class CollectInputs(StripeObject):

stripe/test_helpers/_test_clock.py

@@ -41,6 +41,7 @@ class TestClock(
     OBJECT_NAME: ClassVar[Literal["test_helpers.test_clock"]] = (
         "test_helpers.test_clock"
     )
+    _has_deleted_version = True
 
     class StatusDetails(StripeObject):
         class Advancing(StripeObject):

tests/test_stripe_object.py

@@ -6,8 +6,10 @@
 import pytest
 
 import stripe
+from stripe._customer import Customer
 from stripe._invoice import Invoice
 from stripe._stripe_object import StripeObject
+from stripe.billing._alert import Alert
 
 # We use this because it has a map, "restriction.currency_options" from string -> CurrencyOptions nested class.
 SAMPLE_PROMOTION_CODE = json.loads(
@@ -313,6 +315,33 @@ def test_deletion_metadata(self):
         with pytest.raises(KeyError):
             obj.metadata["key"]
 
+    def test_non_deleted_deletable_resource(self):
+        """
+        if it's possible for an object to be deleted, you should be able to read th
+        """
+        customer = Customer()
+        assert customer.deleted is None
+        assert hasattr(customer, "deleted")
+        # this is a little confusing. since we're faking that this property exist, checks that access the underlying data disagree with property access
+        assert "deleted" not in customer
+
+    def test_deleted_property_reads(self):
+        """
+        certain objects have a `deleted` property that's None or true. Because of the way missing property access works, you couldn't write `if customer.deleted` because that was either true or an error.
+
+        Instead, we now initialize that property on objects that can be `deleted`, so the check works as expected
+        """
+        customer = Customer.construct_from({"deleted": True}, None)
+        assert customer.deleted
+        assert hasattr(customer, "deleted")
+        assert "deleted" in customer
+
+    def test_no_deleted_property_fails(self):
+        # an alert can never be `deleted`, so this should always error
+        alert = Alert()
+        with pytest.raises(AttributeError):
+            alert.deleted
+
     def test_copy(self):
         nested = StripeObject.construct_from({"value": "bar"}, "mykey")
         obj = StripeObject.construct_from(