Bugfix: ValidatesOpenApiSchema trait fails on non-JSON responses#16
Merged
Bugfix: ValidatesOpenApiSchema trait fails on non-JSON responses#16
Conversation
…review - Fail with Content-Type mismatch message instead of misleading "body is empty" - Wrap json() in try-catch for clear error on unparseable body - Case-insensitive Content-Type check for HTTP spec compliance - Add tests for charset, vendor JSON types, and missing header - Simplify header bag constructor with array_change_key_case()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
assertResponseMatchesOpenApiSchema()が非JSONレスポンス（HTMLリダイレクトなど）で$response->json()を呼び出してクラッシュする問題を修正。Content-Typeヘッダーを確認してからJSONパースを行うようにした。変更内容
ValidatesOpenApiSchemaトレイトにextractJsonBody()メソッドを追加し、Content-Typeヘッダーにjsonが含まれない場合はnullを返すように変更CreatesTestResponseヘルパーにヘッダーサポートを追加（$headersパラメータ追加）関連情報