Bugfix: スペックにJSON系コンテンツタイプがないレスポンスで failure になるリグレッション修正#21
Merged
Conversation
…e skip logic Add explanatory comments to clarify skip/mismatch behavior in the validator and Laravel trait. Add tests for mixed JSON and non-JSON content types (valid and invalid bodies) and an integration test confirming non-JSON endpoints are skipped but still recorded for coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
v0.6.0（PR #19）で導入された JSON 互換コンテンツタイプ対応により、スペックに JSON 系コンテンツタイプが一切ないエンドポイント（
text/htmlのみ等）で contract test が失敗するリグレッションを修正。変更内容
OpenApiResponseValidator::validate()でfindJsonContentType()がnullを返した場合、failureではなくsuccess（バリデーションスキップ）を返すように変更*_fails→*_skips_validationにリネームし、successを期待するように修正text/htmlのみを定義するエンドポイント（/v1/logout）のリグレッション再現テストを追加petstore-3.0.jsonに/v1/logoutエンドポイントを追加関連情報