Skip to content

fix(picker): show notification instead of empty window when no sessions match #344

Merged
sudo-tee merged 1 commit intosudo-tee:mainfrom
hermandavid:fix/empty-session-picker
Mar 31, 2026
Merged

fix(picker): show notification instead of empty window when no sessions match #344
sudo-tee merged 1 commit intosudo-tee:mainfrom
hermandavid:fix/empty-session-picker

Conversation

@hermandavid
Copy link
Copy Markdown
Contributor

Summary

  • When using fzf as a picker and selecting child sessions with none available, an empty fzf window would open. Snacks handles this gracefully with a built-in "no results" message, but fzf does not.
  • Add an early return in core.select_session() that checks for empty results before opening the picker, showing a contextual notification instead ("No child sessions found" or "No sessions found").

Details

This follows the same pattern already used by the history, reference, and MCP pickers, which all guard against empty item lists before invoking base_picker.pick().

The fix is in core.select_session() rather than in the picker layer, since this is the call site that knows whether we're filtering by parent (child sessions) or listing all sessions, and can provide the appropriate message.

@hermandavid hermandavid changed the title fix(picker): show notification instead of empty window when no sessio… fix(picker): show notification instead of empty window when no sessions match Mar 30, 2026
@sudo-tee
Copy link
Copy Markdown
Owner

Thanks for the PR

Also looks good to me

@sudo-tee sudo-tee merged commit 2546ca5 into sudo-tee:main Mar 31, 2026
5 checks passed
@hermandavid hermandavid deleted the fix/empty-session-picker branch March 31, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants