fix(picker): show notification instead of empty window when no sessions match #344
Merged
sudo-tee merged 1 commit intosudo-tee:mainfrom Mar 31, 2026
Merged
Conversation
Owner
|
Thanks for the PR Also looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core.select_session()that checks for empty results before opening the picker, showing a contextual notification instead ("No child sessions found" or "No sessions found").Details
This follows the same pattern already used by the history, reference, and MCP pickers, which all guard against empty item lists before invoking
base_picker.pick().The fix is in
core.select_session()rather than in the picker layer, since this is the call site that knows whether we're filtering by parent (child sessions) or listing all sessions, and can provide the appropriate message.