Fix hexadecimal parsing and docsbuild failure#169
Merged
wtbarnes merged 7 commits intosunpy:mainfrom Mar 30, 2026
Merged
Conversation
wtbarnes
changed the title
samaloney
approved these changes
Mar 30, 2026
drms/client.py
Outdated
| k_idx = kdf.columns.get_loc(k) | ||
| kdf.loc[idx, kdf.columns[k_idx]] = kdf.loc[idx, kdf.columns[k_idx]].apply(int, base=16) | ||
| kdf[k] = kdf[k].astype(object) | ||
| kdf.loc[idx, k] = values[idx].apply(lambda x: int(x, base=16)) |
Member
There was a problem hiding this comment.
Do you need the lambda here? I think recent pandas will pass the arg/kwargs, but maybe it’s clearer this way?
https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.Series.apply.html
Member
Author
There was a problem hiding this comment.
Good question. The lambda was already there so I kept it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Fixes #167
This PR also fixes a failing gallery example and doctest in the tutorial.
AI Assistance Disclosure
AI tools were used for: