fix: track changes comment text for formatting changes by luccas-harbour · Pull Request #2013 · superdoc-dev/superdoc

luccas-harbour · 2026-02-12T19:09:18Z

This PR tightens tracked-formatting behavior and comment generation for style changes.

Tracks add/remove mark changes only on real inline text (skips run wrapper nodes) to avoid noisy/incorrect tracked-format entries.
Improves removeMarkStep so before/after payloads are built from actual existing mark attrs and avoid duplicate/incorrect entries.
Fixes tracked-change formatting comments by normalizing textStyle attrs before translation, preventing "undefined" values in the generated message. It also an adds support for describing removed style properties.
Adds regression coverage in comments-plugin.test.js.

Before:

After:

linear · 2026-02-12T19:09:21Z

SD-1742 Bug: Style changes in specific document (from SD webpage) apply with lots of undefined

github-actions · 2026-02-12T19:18:03Z

Visual diffs detected

Pixel differences were found in visual tests. This is not blocking — reproduce locally with cd tests/visual && pnpm docs:download && pnpm test to review diffs.

luccas-harbour · 2026-02-12T19:35:16Z

Visual diffs detected

Pixel differences were found in visual tests. This is not blocking — reproduce locally with cd tests/visual && pnpm docs:download && pnpm test to review diffs.

The visual test that failed is related to this PR which hasn't been merged yet: #1995

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d53d326547

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

packages/super-editor/src/extensions/track-changes/trackChangesHelpers/addMarkStep.js

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 85da4cf907

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

packages/super-editor/src/extensions/comment/comments-plugin.js

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b24dd078d4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

packages/super-editor/src/extensions/comment/comments-plugin.js

tupizz

lgtm

…-document-from-sd-webpage-apply

harbournick

LGTM

superdoc-bot · 2026-02-18T06:53:19Z

🎉 This PR is included in superdoc v1.15.0-next.11

The release is available on GitHub release

# [1.15.0](v1.14.0...v1.15.0) (2026-02-20) ### Bug Fixes * **ai-actions:** preserve html/markdown insertion and prevent repeated formatted replacement ([#2117](#2117)) ([9f685e9](9f685e9)) * **ai:** support headless mode in EditorAdapter.applyPatch ([#1859](#1859)) ([cf9275d](cf9275d)) * **collaboration:** memory leaks, Vue stack overflow, and Liveblocks stability (SD-1924) ([#2030](#2030)) ([a6827fd](a6827fd)), closes [#prepareDocumentForExport](https://github.com/superdoc-dev/superdoc/issues/prepareDocumentForExport) * **collab:** prevent stale view when remote Y.js changes bypass sdBlockRev increment ([#2099](#2099)) ([0895a93](0895a93)) * **converter:** handle null list lvlText and always clear numbering cache ([#2113](#2113)) ([336958c](336958c)) * **document-api:** remove search match cap and validate moveComment bounds ([6d3de67](6d3de67)) * export docx blobs with docx mime type ([#1849](#1849)) ([1bc466d](1bc466d)) * **export:** prevent DOCX corruption from entity encoding and orphaned delInstrText (SD-1943) ([#2102](#2102)) ([56e917f](56e917f)), closes [#replaceSpecialCharacters](https://github.com/superdoc-dev/superdoc/issues/replaceSpecialCharacters) [#1988](#1988) * **layout-bridge:** correct cell selection for tables with rowspan ([#1839](#1839)) ([0b782be](0b782be)) * **layout,converter:** text box rendering and page-relative anchor positioning (SD-1331, SD-1838) ([#2034](#2034)) ([3947f39](3947f39)) * **layout:** route list text-start calculations through resolveListTextStartPx ([02b14b8](02b14b8)) * **painter-dom:** use absolute page Y for page-relative anchors in header/footer decorations ([0b9bc72](0b9bc72)) * preserve selection highlight when opening toolbar dropdowns ([#2097](#2097)) ([a33568e](a33568e)) * structured content renders correct on hover and select ([#1843](#1843)) ([dab3f04](dab3f04)) * **super-editor:** add unsupported-content reporting across HTML/Markdown import paths ([#2115](#2115)) ([84880b7](84880b7)) * **super-editor:** handle partial comment file-sets and clean up stale parts on export ([#2123](#2123)) ([f63ae0a](f63ae0a)) * **super-editor:** restore <hr> contentBlock parsing and harden VML HR export fallback ([#2118](#2118)) ([da51b1f](da51b1f)) * table headers are incorrectly imported from html ([#2112](#2112)) ([e8d1480](e8d1480)) * table resizing regression ([#2091](#2091)) ([20ed24e](20ed24e)) * table resizing regression ([#2091](#2091)) ([9a07f1c](9a07f1c)) * **tables:** align tableHeader attrs with tableCell to fix oversized DOCX export widths ([#2114](#2114)) ([38f0430](38f0430)) * **tables:** fix autofit column scaling, cell width overflow, and page break splitting ([#1987](#1987)) ([61a3f6f](61a3f6f)) * **tables:** prevent tblInd double-shrink when using tblGrid widths (SD-1494) ([8750ece](8750ece)) * track changes comment text for formatting changes ([#2013](#2013)) ([b2a43ff](b2a43ff)) * wire DocumentApi to Editor.doc with lifecycle-safe caching ([57326ea](57326ea)) ### Features * cropped images ([#1940](#1940)) ([3767a49](3767a49)) * extend document-api with format, examples, create.heading ([#2092](#2092)) ([fdf8c7c](fdf8c7c)) * **lists:** support hidden list indicators via w:vanish ([#2069](#2069)) ([#2080](#2080)) ([0bed0fd](0bed0fd)) * the document API limited alpha ([#2087](#2087)) ([091c24c](091c24c))

harbournick · 2026-02-20T02:09:37Z

🎉 This PR is included in superdoc v1.15.0

The release is available on GitHub release

luccas-harbour changed the title ~~fix: correctly track formatting changes~~ fix: correctly compare before/after formatting changes Feb 12, 2026

luccas-harbour changed the title ~~fix: correctly compare before/after formatting changes~~ fix: compare before/after formatting changes Feb 12, 2026

luccas-harbour requested review from VladaHarbour, artem-harbour, caio-pizzol and harbournick February 12, 2026 19:36

luccas-harbour marked this pull request as ready for review February 12, 2026 19:37

chatgpt-codex-connector bot reviewed Feb 12, 2026

View reviewed changes

packages/super-editor/src/extensions/track-changes/trackChangesHelpers/addMarkStep.js Outdated Show resolved Hide resolved

caio-pizzol assigned luccas-harbour Feb 12, 2026

luccas-harbour marked this pull request as draft February 12, 2026 20:51

fix: correctly generate comment text for formatting changes

85da4cf

luccas-harbour force-pushed the luccas/sd-1742-bug-style-changes-in-specific-document-from-sd-webpage-apply branch from d53d326 to 85da4cf Compare February 12, 2026 21:08

luccas-harbour marked this pull request as ready for review February 12, 2026 21:09

luccas-harbour changed the title ~~fix: compare before/after formatting changes~~ fix: track changes comment text for formatting changes Feb 12, 2026

chatgpt-codex-connector bot reviewed Feb 12, 2026

View reviewed changes

packages/super-editor/src/extensions/comment/comments-plugin.js Outdated Show resolved Hide resolved

luccas-harbour marked this pull request as draft February 12, 2026 21:16

luccas-harbour added 2 commits February 12, 2026 18:45

fix: track mark changes only in text nodes

05ad6f8

fix: tracking mark removal

a10ac25

luccas-harbour force-pushed the luccas/sd-1742-bug-style-changes-in-specific-document-from-sd-webpage-apply branch 2 times, most recently from 73d9d03 to ab2d2b1 Compare February 12, 2026 22:40

fix: normalization of textStyle mark

b24dd07

luccas-harbour force-pushed the luccas/sd-1742-bug-style-changes-in-specific-document-from-sd-webpage-apply branch from ab2d2b1 to b24dd07 Compare February 12, 2026 22:54

luccas-harbour marked this pull request as ready for review February 12, 2026 22:57

chatgpt-codex-connector bot reviewed Feb 12, 2026

View reviewed changes

packages/super-editor/src/extensions/comment/comments-plugin.js Show resolved Hide resolved

tupizz approved these changes Feb 13, 2026

View reviewed changes

caio-pizzol added the risk: sensitive label Feb 16, 2026

missysuperdoc added the priority: high label Feb 17, 2026

Merge branch 'main' into luccas/sd-1742-bug-style-changes-in-specific…

1f003ab

…-document-from-sd-webpage-apply

harbournick approved these changes Feb 18, 2026

View reviewed changes

harbournick merged commit b2a43ff into main Feb 18, 2026
6 checks passed

harbournick deleted the luccas/sd-1742-bug-style-changes-in-specific-document-from-sd-webpage-apply branch February 18, 2026 06:50

superdoc-bot bot added the released on @next label Feb 18, 2026

superdoc-dev deleted a comment from github-actions bot Feb 18, 2026

harbournick added the released on @latest label Feb 20, 2026

Comments

Conversation

luccas-harbour commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear bot commented Feb 12, 2026

Uh oh!

github-actions bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Visual diffs detected

Uh oh!

luccas-harbour commented Feb 12, 2026

Visual diffs detected

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

tupizz left a comment

Choose a reason for hiding this comment

Uh oh!

harbournick left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

superdoc-bot bot commented Feb 18, 2026

Uh oh!

harbournick commented Feb 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

luccas-harbour commented Feb 12, 2026 •

edited

Loading

github-actions bot commented Feb 12, 2026 •

edited

Loading