Skip to content

accept object or JSON string for filters query param#785

Open
ved015 wants to merge 1 commit intosupermemoryai:mainfrom
ved015:add/filter_schema
Open

accept object or JSON string for filters query param#785
ved015 wants to merge 1 commit intosupermemoryai:mainfrom
ved015:add/filter_schema

Conversation

@ved015
Copy link
Contributor

@ved015 ved015 commented Mar 18, 2026

Summary

  • Fixes a mismatch where filters was documented/used as an object but validated as a string
  • ListMemoriesQuerySchema.filters now accepts either
    • a structured filters object or
    • a JSON encoded string
  • OpenAPI metadata updated with examples for both shapes

What changed

  • Added SearchFiltersParamSchema (union of object + JSON string -> parsed object) validated via SearchFiltersSchema
  • Updated ListMemoriesQuerySchema.filters to use SearchFiltersParamSchema

@Dhravya @MaheshtheDev please have a look

@graphite-app graphite-app bot requested a review from Dhravya March 18, 2026 14:54
@ved015
Copy link
Contributor Author

ved015 commented Mar 18, 2026

FYI the Claude Code Review workflow is failing on this PR because it is from a fork.
I check and since the action tries to fetch a GitHub OIDC token, but for pull_request runs from forks idts GitHub provides the OIDC env vars / secrets so it fails

@ved015
Copy link
Contributor Author

ved015 commented Mar 18, 2026

@claude review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant