Skip to content

perf(middleware): await background task cancellation on timeout #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ishaanxgupta wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf(middleware): await background task cancellation on timeout #786

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/openai-sdk-python/src/supermemory_openai/middleware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,9 +554,12 @@ async def wait_for_background_tasks(self, timeout: Optional[float] = 10.0) -> No
f"Background tasks did not complete within {timeout}s timeout"
)
# Cancel remaining tasks
for task in self._background_tasks:
if not task.done():
task.cancel()
tasks_to_cancel = [task for task in self._background_tasks if not task.done()]
for task in tasks_to_cancel:
task.cancel()

if tasks_to_cancel:
await asyncio.gather(*tasks_to_cancel, return_exceptions=True)
raise

def cancel_background_tasks(self) -> None:
Expand Down