Fix NumberFormatException and refactor YahooWeatherProvider#40
Open
m-rm wants to merge 23 commits intosurvivingwithandroid:masterfrom
Open
Fix NumberFormatException and refactor YahooWeatherProvider#40m-rm wants to merge 23 commits intosurvivingwithandroid:masterfrom
m-rm wants to merge 23 commits intosurvivingwithandroid:masterfrom
Conversation
…stria (Wind direction and speed is an empty String)
Owner
|
Hi, |
Contributor
Author
|
I added a new commit which implements the recent API changes from Yahoo. |
… Gradle plugin > 2.1.2
… Gradle plugin > 2.1.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, basically each commit describes what has been done. I only want to describe "Unify parsing of current weather and forecast" a bit:
Parsing of current and forecast weather was done in similar ways, with a lot of redundant code in both methods. I created a single method to parse it and choose afterwards if current or forecast weather is needed. This has some nice side effects: