fix: install @bettter-auth/cli as a dev dependency#950
fix: install @bettter-auth/cli as a dev dependency#950sacrosanctic wants to merge 8 commits intosveltejs:mainfrom
@bettter-auth/cli as a dev dependency#950Conversation
🦋 Changeset detectedLatest commit: 03fc947 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
|
An even better way could be to add |
@bettter-auth/cli as a dev dependency
| "sv": patch | ||
| --- | ||
|
|
||
| fix: install `@bettter-auth/cli` as a dev dependency |
There was a problem hiding this comment.
| fix: install `@bettter-auth/cli` as a dev dependency | |
| fix: install `@better-auth/cli` as a dev dependency |
;)
|
|
||
| - **npm** : `npx sv create` | ||
| - **pnpm** : `pnpx sv create` or `pnpm dlx sv create` | ||
| - **pnpm** : `pnpm dlx sv create` |
There was a problem hiding this comment.
Even though as per your link in the PR description, pnpx is not always there by default, I'm pretty sure it exists and is both used and preferred by the vast majority of pnpm users, and probably won't go away anytime soon. I'd argue to leave it as it was, or at least invert the original commands ("pnpm dlx ... or pnpx ...")
|
|
||
| ```sh | ||
| npm i -g pnpm | ||
| npm i -g corepack@latest |
There was a problem hiding this comment.
Maybe add a line or two to explain why specifically use corepack over the user's install, if it even is mandatory to use the corepack version?
Your sources explain why corepack is still a viable install method, but don't mention any specific advantage over any other installation method. Maybe removing this block altogether and let the user install it however they want is simpler to manage?
closes #937
in this pr:
pnpm dlx(src)createandaddargs to a specific version for reproducibility