Fix bug with response header creation#892
Merged
fabianfett merged 2 commits intoswift-server:ff-new-http-client-apifrom Feb 25, 2026
Merged
Fix bug with response header creation#892fabianfett merged 2 commits intoswift-server:ff-new-http-client-apifrom
fabianfett merged 2 commits intoswift-server:ff-new-http-client-apifrom
Conversation
When converting the AHC headers to the HTTP API compatible headers, headers with the same name and different values should be inserted instead of being replaced. This change now allows AHC to pass some header conformance tests.
fabianfett
approved these changes
Feb 25, 2026
…tp-client into fix-header-bug
fabianfett
merged commit 58d9e21
into
swift-server:ff-new-http-client-api
30 of 32 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When converting the AHC headers to the HTTP API compatible headers, headers with the same name and different values should be inserted instead of being replaced.
Doing
responseFields[name] = valuewould cause a replacement instead of adding a new header.We want
responseFields.append(field)instead.This change now allows AHC to pass some header conformance tests.