Conversation
|
Thanks for the PR. I agree with you that it's good to have a dedicated method for this. Before I can accept the PR it needs a bit of love, though. The new code should be covered by a unit test. Maybe you could also write a little bit about this in the "Generating Keys" section of |
|
Thank you for your reply. I've written a test case in the Hope this is fine now. |
|
It's been a week since I fixed this PR. Is this okay now or is there something I need to change? |
|
From a glance it looks good, thanks. For personal reasons I can't spend more brain power on this now, sorry. I'll get back to you, no worries. If there happen to be things to change, I'll be explicit in what & how. |
I know it's not that much of an important feature as a public key can be generated from a private key by simply doing
but I still find a separate method to be convenient as it eliminates a possible source of errors and increases readability.
With the rather simple implementation this would be just