Open
Conversation
|
Thanks for this work! I don't know enough about the Haskell bindings to be able to properly review. If no other maintainer comes along please comment and I'll attempt a review anyway. |
|
@twesterhout thanks for your work! I just gave you a write access to this repository, so if you wouldn't mind maintaining the Haskell wrappers we would really appreciate it. I would say go ahead and merge once you are happy and things work. Thanks for setting up the GitHub CI. If you need anything else, please let me know. |
… containers and unordered-containers libraries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I'm considering using SymEngine for a project of mine, and was playing around with Haskell wrappers. This PR updates
symengine.cabalto support building with GHC 8.10.7 and recent Cabal. I've also added support for Github Actions workflow. The build itself works on both Linux and Mac, but Mac tests crash. This should be investigated further (and I leave it for another PR). For now, I've disabled all but the ascii art test.