Skip to content

chore: use e2e updater url for e2e builds#856

Merged
ovitrif merged 1 commit intomasterfrom
chore/e2e-updater-url
Mar 19, 2026
Merged

chore: use e2e updater url for e2e builds#856
ovitrif merged 1 commit intomasterfrom
chore/e2e-updater-url

Conversation

@piotr-iohk
Copy link
Collaborator

This PR points E2E builds to a separate updater release.json hosted in bitkit-e2e-tests, so production critical updates don't block E2E test runs.

Description

The production updater currently has critical: true for both platforms. E2E builds from master with lower build numbers hit the blocking CriticalUpdate screen immediately, making all tests fail.

When isE2eTest is true, RELEASE_URL now resolves to:
https://github.com/synonymdev/bitkit-e2e-tests/releases/download/updater/release.json

That file has buildNumber: 0, critical: false by default, so E2E builds are never blocked. When update flow testing is needed, the E2E release.json can be updated independently.

Preview

N/A

QA Notes

  1. Build with E2E=true and verify the app does not show a critical update screen on startup
  2. Build without E2E=true and verify the production updater still works as before

Made with Cursor

@piotr-iohk piotr-iohk self-assigned this Mar 19, 2026
@claude
Copy link

claude bot commented Mar 19, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

Copy link
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ovitrif ovitrif enabled auto-merge March 19, 2026 14:26
@ovitrif ovitrif merged commit c362ac0 into master Mar 19, 2026
40 of 44 checks passed
@ovitrif ovitrif deleted the chore/e2e-updater-url branch March 19, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants