Open
Conversation
chore: update ldk-node to 0.7.0-rc.36 chore: review chore: bump ldk-node to rc.35
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
jvsena42
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #847
Release 2.1.2 — includes stale channel monitors recovery and version bump.
see also:
Description
DangerousValueerror to protect funds. This catches that error and retries the build withaccept_stale_channel_monitorsenabled, allowing ldk-node to accept the stale monitor and self-heal via commitment round-trips with the channel peer.versionCode: 179 → 180versionName: 2.1.1 → 2.1.2Preview
Screenshot of activity list after recovery.
The transactions are part of the setup to reproduce the issue.
QA Notes
1. Normal startup (unaffected users)
2. Stale monitor recovery
2.1.2DangerousValueandaccept_stale_channel_monitorsStale monitor recovery: all monitors healedappears in logs within ~15s3. Connection timeout (optional)