Prevent Redirector Abuse - Reverse Tabnabbing#1
Open
mavaras wants to merge 1 commit intosyrex88:masterfrom
Open
Prevent Redirector Abuse - Reverse Tabnabbing#1mavaras wants to merge 1 commit intosyrex88:masterfrom
mavaras wants to merge 1 commit intosyrex88:masterfrom
Conversation
- This library is vulnerable to this kind of attack. I presume every user of jquery-comments is exposed to this attack - According to https://cwe.mitre.org/data/definitions/1022.html we can avoid this by simply adding a rel parameter to our links - js/jquery-comments.js a tags modified including rel parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.