Corrected some long-form getopt option-specifiers#3
Open
mikehaben69 wants to merge 1 commit intosysmocom:masterfrom
Open
Corrected some long-form getopt option-specifiers#3mikehaben69 wants to merge 1 commit intosysmocom:masterfrom
mikehaben69 wants to merge 1 commit intosysmocom:masterfrom
Conversation
…ls sign, otherwise the following argument is not parsed correctly
Member
|
Thanks! Please note that github is just a read-only mirror of the tool, which is maintained at https://gitea.sysmocom.de/sysmocom/sysmo-usim-tool It would be great if you could raise your PR there, so we can review + merge there before it will be mirrored back to github as a read-only mirror. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The set-imsi, set-mnclen and set-milenage option specifier strings each need a trailing equals sign, otherwise the getopt.getopt() function does not parse the subsequent argument correctly. Symptom is that
python3 sysmo-isim-tool.sja2.py --adm1 12345678 -J 001010000056789
works, but
python3 sysmo-isim-tool.sja2.py --adm1 12345678 --set-imsi 001010000056789
does not (and similarly -N works but --set-mnclen does not).