fix(errors): prioritize permission errors over 'does not exist' warnings#11
Merged
fix(errors): prioritize permission errors over 'does not exist' warnings#11
Conversation
filterErr checked 'does not exist' before 'Interactive authentication required', so when systemd printed both (common for mask/unmask on non-installed units as a non-root user), the wrong error was returned. Reorder checks so permission, bus, and masked errors take priority over existence warnings. Add tests covering mixed-stderr scenarios. Also: - CI: install and start nginx so user + root tests pass - CI: run tests as both user and root for full coverage - Bump Go 1.26 → 1.26.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Bug fix: filterErr error priority
filterErrcheckeddoes not existbeforeInteractive authentication required, so when systemd printed both (common for mask/unmask on non-installed units as a non-root user), the wrong error was returned —ErrDoesNotExistinstead ofErrInsufficientPermissions.Reordered checks so permission, bus, and masked errors take priority over existence warnings. The "does not exist, proceeding anyway" message from systemd is a warning, not a failure — the actual failure is the permission denial.
Tests
filterErrtest cases covering mixed-stderr scenariosErrInsufficientPermissionsnowCI improvements
Misc
Testing
go test -run TestFilterErr— all 14 cases passgo test -run TestMask— all user cases passgo test -run TestUnmask— all user cases passstaticcheck ./...— clean