Open
Conversation
Member
|
@vashisthg I would not have the library support two different versions of RxJava like this. Especially not given the duplication this solution adds. It also strips the rx-java2 part of acceptance tests. |
Author
|
@nilsen340 For the new version of tapglue sdk why to keep support for rxjava1? |
Author
|
Let me know about the acceptance tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement rxJava 2.x api
This PR intends to add rxJava2 api in tapglue.
For this had to create a new lib module tapglue-android-sdk-rxjava2 which just has dependency on rxjava2 only. The older tapglue-android-sdk has dependency on rxjava 1.x.
To reuse as much as I could extracted two modules 'entities' and 'core'. tapglue-android-sdk-rxjava2 and tapglue-android-sdk depends on 'entities' and 'core'.
Please have a look.
Things to do: