Convert ArtifactProvider to dataclass#4765
Merged
happz merged 1 commit intoteemtee:mainfrom Apr 14, 2026
Merged
Conversation
LecrisUT
added
ci | full test
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the ArtifactProvider base class and its subclasses to use the @container decorator and post_init pattern, replacing traditional init methods. Key changes include the introduction of simple_field for attribute management, converting sanitized_id to a cached property, and cleaning up associated imports. I have no feedback to provide.
LecrisUT
force-pushed
the
chore/dataclass-artifact-provider
branch
from
94065d8 to
e998717
Compare
happz
force-pushed
the
chore/dataclass-artifact-provider
branch
from
e998717 to
e67470a
Compare
Member
Author
|
/packit retest-failed |
vaibhavdaren
approved these changes
Apr 13, 2026
Contributor
|
Shows test cancelled. Running Again. The change is LGTM. /packit retest-failed |
tcornell-bus
approved these changes
Apr 13, 2026
happz
approved these changes
Apr 13, 2026
Signed-off-by: Cristian Le <git@lecris.dev>
happz
force-pushed
the
chore/dataclass-artifact-provider
branch
from
e67470a to
7bdeb14
Compare
Contributor
|
/packit rebuild-failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making changes to the constructor is a pain otherwise