chore: referencing the setup-kind script from the plumbing repo instead of copying it#2590
chore: referencing the setup-kind script from the plumbing repo instead of copying it#2590infernus01 wants to merge 1 commit intotektoncd:mainfrom
Conversation
|
/ok-to-test |
501924b to
7951c83
Compare
|
/ok-to-test |
|
/lgtm |
|
/ok-to-test |
|
Did the CI run? Since we already have |
It seems there is some issue, can you try to rebase the PR? |
7951c83 to
e3e9fd3
Compare
|
@infernus01 can you rebase ? |
e3e9fd3 to
c7a0906
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
c7a0906 to
169cdde
Compare
|
/lgtm |
|
@infernus01 can you please rebase it? |
|
@infernus01 are you still planning to rebase this? It addresses #2520 and the approach looks good, but it's fallen behind main. Let us know if you need help or if we should pick this up. |
|
Thanks for reminding, got pulled into priorities. On it now. |
169cdde to
6eb568d
Compare
|
New changes are detected. LGTM label has been removed. |
6eb568d to
3a078fd
Compare
… of copying it Signed-off-by: Shubham Bhardwaj <shubbhar@redhat.com>
3a078fd to
01e9bee
Compare
|
@vdemeester If we could merge tektoncd/plumbing#3187, I guess we could be able to simply the workflow. |
|
/retest |
Changes
Fixes #2520
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes