Makefile: fix lint-go with workflow version and project Go toolchain#2734
Makefile: fix lint-go with workflow version and project Go toolchain#2734tekton-robot merged 1 commit intotektoncd:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This patch updates Makefile to use GOLANGCI_VERSION from ci.yaml (fallback to tools/go.mod) and GOTOOLCHAIN from go.mod when installing so golangci-lint is built with the project’s Go version also adds inline comments to skip gosec and revive lint. Signed-off-by: Shiv Verma <shverma@redhat.com>
divyansh42
left a comment
There was a problem hiding this comment.
Changes looks good.
@pratap0007 Can we check if we can make changes to the code (Wherever possible) to make the linter green instead of disabling the linter at multiple places?
We can fix the gosec lint issues, but it will require refactoring the code and testing. This will take some time and may delay the release. Would it be okay to address this in a separate PR? |
|
/lgtm |
#2729 | [dependabot[bot]] Bump the go-k8s-dependencies group with 3 updates | 2026/02/18-13:42 #2735 | [dependabot[bot]] Bump github.com/golangci/golangci-lint/v2 in /tools | 2026/02/18-16:30 #2730 | [dependabot[bot]] Bump github.com/tektoncd/triggers from 0.34.0 to 0.35.0 | 2026/02/21-14:40 #2737 | [dependabot[bot]] Bump github.com/tektoncd/pipeline from 1.9.0 to 1.9.1 | 2026/02/22-14:12 #2736 | [dependabot[bot]] Bump filippo.io/edwards25519 from 1.1.0 to 1.1.1 | 2026/02/22-15:40 #2738 | [dependabot[bot]] Bump github.com/google/go-containerregistry from 0.20.7 to 0.21.0 | 2026/02/23-04:22 #2734 | [Shiv Verma] Makefile: fix lint-go with workflow version and project Go toolchain | 2026/02/23-09:16 #2739 | [Shiv Verma] Switch hub dependency org to openshift-pipelines | 2026/02/23-12:32 Signed-off-by: Shiv Verma <shverma@redhat.com>
This patch updates Makefile to use GOLANGCI_VERSION from ci.yaml (fallback to tools/go.mod) and GOTOOLCHAIN from go.mod when installing so golangci-lint is built with the project’s Go version.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes