Skip to content

Makefile: fix lint-go with workflow version and project Go toolchain#2734

Merged
tekton-robot merged 1 commit intotektoncd:mainfrom
pratap0007:fix-lint
Feb 23, 2026
Merged

Makefile: fix lint-go with workflow version and project Go toolchain#2734
tekton-robot merged 1 commit intotektoncd:mainfrom
pratap0007:fix-lint

Conversation

@pratap0007
Copy link
Contributor

This patch updates Makefile to use GOLANGCI_VERSION from ci.yaml (fallback to tools/go.mod) and GOTOOLCHAIN from go.mod when installing so golangci-lint is built with the project’s Go version.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 18, 2026
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 18, 2026
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2026
This patch updates Makefile to use GOLANGCI_VERSION from
ci.yaml (fallback to tools/go.mod) and GOTOOLCHAIN from go.mod
when installing so golangci-lint is built with the project’s Go version
also adds inline comments to skip gosec and revive lint.

Signed-off-by: Shiv Verma <shverma@redhat.com>
Copy link
Member

@divyansh42 divyansh42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.
@pratap0007 Can we check if we can make changes to the code (Wherever possible) to make the linter green instead of disabling the linter at multiple places?

@pratap0007
Copy link
Contributor Author

Changes looks good. @pratap0007 Can we check if we can make changes to the code (Wherever possible) to make the linter green instead of disabling the linter at multiple places?

We can fix the gosec lint issues, but it will require refactoring the code and testing. This will take some time and may delay the release. Would it be okay to address this in a separate PR?

@divyansh42
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2026
@tekton-robot tekton-robot merged commit 3fa1ef2 into tektoncd:main Feb 23, 2026
11 checks passed
pratap0007 added a commit that referenced this pull request Feb 23, 2026
#2729 | [dependabot[bot]] Bump the go-k8s-dependencies group with 3 updates | 2026/02/18-13:42
#2735 | [dependabot[bot]] Bump github.com/golangci/golangci-lint/v2 in /tools | 2026/02/18-16:30
#2730 | [dependabot[bot]] Bump github.com/tektoncd/triggers from 0.34.0 to 0.35.0 | 2026/02/21-14:40
#2737 | [dependabot[bot]] Bump github.com/tektoncd/pipeline from 1.9.0 to 1.9.1 | 2026/02/22-14:12
#2736 | [dependabot[bot]] Bump filippo.io/edwards25519 from 1.1.0 to 1.1.1 | 2026/02/22-15:40
#2738 | [dependabot[bot]] Bump github.com/google/go-containerregistry from 0.20.7 to 0.21.0 | 2026/02/23-04:22
#2734 | [Shiv Verma] Makefile: fix lint-go with workflow version and project Go toolchain | 2026/02/23-09:16
#2739 | [Shiv Verma] Switch hub dependency org to openshift-pipelines | 2026/02/23-12:32

Signed-off-by: Shiv Verma <shverma@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants