Skip to content

Add Poller Group fields#744

Open
ShahabT wants to merge 5 commits intomasterfrom
shahab/mcn
Open

Add Poller Group fields#744
ShahabT wants to merge 5 commits intomasterfrom
shahab/mcn

Conversation

@ShahabT
Copy link
Contributor

@ShahabT ShahabT commented Mar 24, 2026

  • Add poller groups
  • rename resource_id to routing key for nexus
  • fix typo
  • Add poller group fields

What changed?
Adding poller-group-id and poller-group-info fields to the poll APIs.

Why?
SDK needs to pass poller group ID in some APIs according to server instructions.

Breaking changes
None

Server PR
No new API added.

@ShahabT ShahabT requested review from a team March 24, 2026 23:47
message PollWorkflowTaskQueueRequest {
string namespace = 1;
temporal.api.taskqueue.v1.TaskQueue task_queue = 2;
// Client must pass one of the poller group IDs received in `poller_group_infos` of the last
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we clarify that is expected to be unset the first time?

temporal.api.taskqueue.v1.PollerScalingDecision poller_scaling_decision = 3;
// Should be returned in RespondNexusTaskCompletedRequest and RespondNexusTaskFailedRequest
// for proper routing of handler's response.
string routing_key = 4;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Routing key is new to me. How does this differ from poller_group_id, or is it meant to have been replaced?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants