Skip to content

Gate features-specific python build behind conditional #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
THardy98 merged 1 commit into from
Mar 24, 2026
Merged

Gate features-specific python build behind conditional #787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions sdkbuild/python.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,14 +120,16 @@ requires-python = "~=3.10"
if err := executeCommand("uv", "add", "--dev", "mypy"); err != nil {
return nil, fmt.Errorf("failed installing mypy: %w", err)
}

// Create __init__.py files in feature directories to make them proper Python packages
if err := executeCommand("find", "../features", "-type", "d", "-exec", "touch", "{}/__init__.py", ";"); err != nil {
return nil, fmt.Errorf("failed creating __init__.py files: %w", err)
}

if err := executeCommand("uv", "run", "mypy", "--explicit-package-bases", "../features"); err != nil {
return nil, fmt.Errorf("failed type checking: %w", err)
if _, err := os.Stat(filepath.Join(dir, "../features")); err == nil {
if err := executeCommand("find", "../features", "-type", "d", "-exec", "touch", "{}/__init__.py", ";"); err != nil {
return nil, fmt.Errorf("failed creating __init__.py files: %w", err)
}

if err := executeCommand("uv", "run", "mypy", "--explicit-package-bases", "../features"); err != nil {
return nil, fmt.Errorf("failed type checking: %w", err)
}
}

success = true
Expand Down
Loading