Add field to build dotnet in release mode#788
Merged
Conversation
THardy98
force-pushed
the
feat/dotnet-release-mode
branch
from
19a964e to
b633e27
Compare
yuandrew
approved these changes
Mar 24, 2026
| } else if options.CsprojContents == "" { | ||
| return nil, fmt.Errorf("csproj contents required") | ||
| } else if options.Configuration != "" && options.Configuration != "Debug" && options.Configuration != "Release" { | ||
| return nil, fmt.Errorf("configuration must be empty, \"Debug\", or \"Release\", got %q", options.Configuration) |
Contributor
There was a problem hiding this comment.
not sure if you need to specify, being empty, since the user will always be specifying to see an err message here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
DWISOTT