Fix time skipping for dotnet SDK#2805
Merged
Quinn-With-Two-Ns merged 4 commits intotemporalio:masterfrom Mar 17, 2026
Merged
Conversation
Quinn-With-Two-Ns
force-pushed
the
time-skipping-test-server-nexus-dotnet-fix
branch
from
4c39801 to
bc6bb16
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
...test-server/src/main/java/io/temporal/internal/testservice/TestWorkflowMutableStateImpl.java
Show resolved
Hide resolved
temporal-test-server/src/main/java/io/temporal/internal/testservice/TestWorkflowService.java
Show resolved
Hide resolved
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1d3c13c184
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
...test-server/src/main/java/io/temporal/internal/testservice/TestWorkflowMutableStateImpl.java
Show resolved
Hide resolved
temporal-test-server/src/main/java/io/temporal/internal/testservice/TestWorkflowService.java
Show resolved
Hide resolved
tconley1428
approved these changes
Mar 16, 2026
Quinn-With-Two-Ns
force-pushed
the
time-skipping-test-server-nexus-dotnet-fix
branch
from
8c01c0c to
4edb110
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix time skipping for dotnet SDK. Fix some Graal config and fix some issues with Nexus operation cancellation.
Note
Medium Risk
Touches test-server workflow mutable state and Nexus task handling, including history event emission and timeout behavior; bugs here can change determinism of tests and time-skipping behavior.
Overview
Improves Nexus operation cancellation behavior in the test server by persisting
cancelRequestedEventIdafter an operation is removed, emitting a newEVENT_TYPE_NEXUS_OPERATION_CANCEL_REQUEST_FAILEDhistory event on cancel-handler failure, and ensuring cancel-ack now schedules a workflow task so SDKs can observe the completion event.Also hardens Nexus operation lifecycle edge cases by skipping duplicate
startNexusOperationcalls, avoiding request-timeout handling once an operation isSTARTED, and preserving handler error messages when converting legacyHandlerErrortoFailure. Updates GraalVM reachability metadata to rely onallDeclaredMethodsfor several protobuf types, and adds functional tests covering the new/adjusted Nexus behaviors.Written by Cursor Bugbot for commit 4edb110. This will update automatically on new commits. Configure here.