Skip to content

Display cron string instead of calendar spec when schedule has a cron string in comment field#3241

Open
Alex-Tideman wants to merge 1 commit intomainfrom
cron-string
Open

Display cron string instead of calendar spec when schedule has a cron string in comment field#3241
Alex-Tideman wants to merge 1 commit intomainfrom
cron-string

Conversation

@Alex-Tideman
Copy link
Collaborator

Description & motivation 💭

Users want to see the cron string if entered. Note this will only work if the cron string is added at the comment field in the Spec. The UI does this when creating a Schedule, but not all other interfaces do.

Screenshots (if applicable) 📸

Screenshot 2026-03-20 at 3 09 20 PM Screenshot 2026-03-20 at 3 09 28 PM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@Alex-Tideman Alex-Tideman requested review from a team and rossedfort as code owners March 20, 2026 20:12
@vercel
Copy link

vercel bot commented Mar 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Mar 20, 2026 8:12pm

Request Review

copyable
{inline}
testId="schedule-calendar"
language="json"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ Argument of type 'null' is not assignable to parameter of type '((key: string, value: (IStructuredCalendarSpec | IIntervalSpec)[]) => (IStructuredCalendarSpec | IIntervalSpec)[]) | undefined'.

@temporal-cicd
Copy link
Contributor

temporal-cicd bot commented Mar 20, 2026

Warnings
⚠️

📊 Strict Mode: 1 error in 1 file (0.1% of 1089 total)

src/lib/components/schedule/schedule-frequency.svelte (1)
  • L49:50: Argument of type 'null' is not assignable to parameter of type '((key: string, value: (IStructuredCalendarSpec | IIntervalSpec)[]) => (IStructuredCalendarSpec | IIntervalSpec)[]) | undefined'.

Generated by 🚫 dangerJS against e874374

@Alex-Tideman
Copy link
Collaborator Author

Note: Fix Schedule Input font size

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants