[DRAFT] [WIP] Architecture Decision Records#170
Draft
sniper7kills wants to merge 5 commits intotenancy:masterfrom
Draft
[DRAFT] [WIP] Architecture Decision Records#170sniper7kills wants to merge 5 commits intotenancy:masterfrom
sniper7kills wants to merge 5 commits intotenancy:masterfrom
Conversation
sniper7kills
changed the title
ArlonAntonius
approved these changes
Oct 22, 2020
Member
ArlonAntonius
left a comment
ArlonAntonius
left a comment
There was a problem hiding this comment.
Looks like a good start to me
| ## 1.x | ||
| ** Use of Config Files ** | ||
|
|
||
| ** Disallow the ordering of Affects ** |
Member
There was a problem hiding this comment.
Disallow sounds so rude, "Do not support", sounds slightly better
| The following are a list of decisions that have been made regarding the architecture of the Tenancy package. | ||
|
|
||
| ## 1.x | ||
| ** Use of Config Files ** |
Member
There was a problem hiding this comment.
No need to use capitalized letters config files
| # Architecture Decision Records | ||
| The following are a list of decisions that have been made regarding the architecture of the Tenancy package. | ||
|
|
||
| ## 1.x |
Member
There was a problem hiding this comment.
All of these should be listed under 0.x
| - architecture | ||
| --- | ||
|
|
||
| # TEMPLATE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Architecture Decision Record Sample.
These really belong in their own folder; likely broken out by version in which the decision was made.