Skip to content

Improve robustness in load_module and harden Dockerfile security #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RinZ27 wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −1
Open

Improve robustness in load_module and harden Dockerfile security #1017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions release/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,4 +86,9 @@ RUN export PIP_BREAK_SYSTEM_PACKAGES=1 PIP_ROOT_USER_ACTION=ignore && \
# Clean up before finishing.
RUN apt-get clean

# Create a non-root user and switch to it.
RUN useradd -m -s /bin/bash tfq-user
USER tfq-user
WORKDIR /home/tfq-user

CMD ["/bin/bash"]
2 changes: 1 addition & 1 deletion tensorflow_quantum/core/ops/load_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def _load(self):
try:
path = resource_loader.get_path_to_datafile(self._name)
self._module = load_library.load_op_library(path)
except:
except Exception: # pylint: disable=broad-except
path = os.path.join(get_python_lib(),
"tensorflow_quantum/core/ops", self._name)
self._module = load_library.load_op_library(path)
Expand Down
Loading