fix: replace deprecated pkg_resources#7026
fix: replace deprecated pkg_resources#7026desaxce wants to merge 2 commits intotensorflow:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Thank you @desaxce ! Sorry for the delay. I will look into this next week! |
|
So sorry for the delay again. Our CI workflows are currently broken because we seem to have reached the limit of the provisioned VM for GH Actions, and it'll take a little while to resolve this. I'll come back to check this when that is resolved. |
|
+1 |
|
The package 'pkg_resources' has now been removed: python -c "import pkg_resources; print('pkg_resources is available')" The old version of setuptools: |
Motivation for features / changes
Fixes #7003
When I run tensorboard, I get the deprecation warning, which I don't want:
Technical description of changes
I replaced all occurrences of
pkg_resourcesby importlib or packaging.version.Screenshots of UI changes (or N/A)
==> not applicable
Detailed steps to verify changes work correctly (as executed by you)
On both master and replace_pkg_resources branches, I ran
bazel run //tensorboard -- --logdir runswith outputs:Output on master:
Output on
replace_pkg_resources(no pkg_resources warning):Alternate designs / implementations considered (or N/A)
--> not applicable