Skip to content

chore: Migrate gsutil usage to gcloud storage #7063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bhandarivijay-png wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

chore: Migrate gsutil usage to gcloud storage #7063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tensorboard/data/server/DEVELOPMENT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ When done, commit the changes to `Cargo.toml`, `Cargo.lock`, and the

Test datasets are stored on Google Cloud Storage in the world-readable
`gs://tensorboard-bench-logs` bucket, whose [bucket README] is online. To run
against this data, use `gsutil` to copy it to your local machine.
against this data, use `gcloud storage` to copy it to your local machine.
Copy link
Copy Markdown
Member

@arcra arcra Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to refer to the actual CLI command provided by google (assuming there is one, and that's why this is change was created), so this change is fine to keep.

Copy link
Copy Markdown

@gurusai-voleti gurusai-voleti Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes gcloud storage is the latest tool instead of gsutil, yes we have this tool


[bucket README]: https://storage.googleapis.com/tensorboard-bench-logs/README

Expand Down
2 changes: 1 addition & 1 deletion tensorboard/data/server/gcs/gsutil.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ use std::io::Write;
use rustboard_core::gcs;

#[derive(Clap, Debug)]
#[clap(name = "gsutil")]
#[clap(name = "gcloud storage")]
Copy link
Copy Markdown
Member

@arcra arcra Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really familiar with this code and the clap library (or Rust, for that matter), but from what I can gather, this might not really be doing anything... I think this is just a testing util (see line 16), and this might be just a display name.

If it's not just a display name, then it probably refers to the testing CLI defined here, which would likely need to keep this name.

AFAICT, the actual interactions with cloud is done via the client here, via http requests.

Copy link
Copy Markdown

@gurusai-voleti gurusai-voleti Apr 8, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as gsutil is deprecated tool and gcloud storage should be used, by this replacement the users can start using gcloud storage instead of gsutil

please let us know if this direct replacement works or not

Copy link
Copy Markdown
Member

@arcra arcra Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

I think this util is not actually using or interacting with the cli util, but (AFAICT) this name change shouldn't affect anywya, so we can merge this change.

struct Opts {
#[clap(long, default_value = "info")]
log_level: String,
Expand Down