moduleProductGrid – Adding Slug to Clean Data#4
Closed
wkhearn wants to merge 1 commit intothe-couch:masterfrom
Closed
moduleProductGrid – Adding Slug to Clean Data#4wkhearn wants to merge 1 commit intothe-couch:masterfrom
wkhearn wants to merge 1 commit intothe-couch:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the moduleProductGrid slug to the data being cleaned and delivered for that module. This is needed to properly utilize the logic set up for the CLP (All Products) nav bar functionality.
More context:
The module slug is referenced in productGrid.js in the Wool & Oak repo on lines 390 and 510, which enables the sticky nav buttons to jump to the correct module. Without the
js-${slug}ID, the CLP nav bar will always have to be manually coded.Clean Data for moduleProductGrid currently:
Nav Bar
handleJumplogic: