Don't include descriptions in the generated DocBlocks #707
+17,153
−126,404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This will probably fail the CI checks because I have not updated the generated files, and I see it does diff with them. |
Contributor
Author
|
There's a PHPStan warning which appears to have arisen as a result of a change to Stan. I'll fix that with a separate PR... |
Contributor
Author
|
shish
force-pushed
the
task/docblock-comments
branch
from
050daf9 to
3cdc92f
Compare
These mostly just duplicate the PHP documenation. Developers are unlikely to refer to these for the PHP documentation, and they can still inspect the return type to confirm that, e.g., `false` will not be returned. Instead, only include the type information. This reduces the size of the generated code from 6.27Mb to 2.79Mb. Part of thecodingmachine#706.
shish
force-pushed
the
task/docblock-comments
branch
from
3cdc92f to
16d0f44
Compare
Collaborator
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These mostly just duplicate the PHP documenation. Developers are unlikely to refer to these for the PHP documentation, and they can still inspect the return type to confirm that, e.g.,
falsewill not be returned.Instead, only include the type information.
This reduces the size of the generated code from 6.27Mb to 2.79Mb.
Part of #706.