Draft: Improvement - Add method annotations in iterator generated classes#242
Draft
dsavina wants to merge 1 commit intothecodingmachine:masterfrom
Draft
Draft: Improvement - Add method annotations in iterator generated classes#242dsavina wants to merge 1 commit intothecodingmachine:masterfrom
dsavina wants to merge 1 commit intothecodingmachine:masterfrom
Conversation
Signed-off-by: Dorian Savina <d.savina@thecodingmachine.com>
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
============================================
- Coverage 97.54% 97.45% -0.10%
- Complexity 1482 1483 +1
============================================
Files 62 62
Lines 4159 4168 +9
============================================
+ Hits 4057 4062 +5
- Misses 102 106 +4
Continue to review full report at Codecov.
|
dsavina
changed the title
Member
|
We could try to use generics from PHPStan / Psalm instead. Especially since PHPStorm reads those annotations since the last version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add type hint for methods
first,toArray,offsetGet,withOrder,withParametersin base iterator classes.