GSOC 2025: Implement adaptive uniformgrid refinement#280
GSOC 2025: Implement adaptive uniformgrid refinement#280tutou2356 wants to merge 11 commits intotheochem:masterfrom
Conversation
Adds the AdaptiveUniformGrid wrapper class to provide recursive subdivision of a uniform grid.
… added test cases - Revised the `_estimate_error` function - Adjusted the weight calculation method to more efficiently update based on new errors - Added test cases for other functions
Ali-Tehrani
left a comment
There was a problem hiding this comment.
Hi @tutou2356, these are my initial changes for the adaptive grid. Let me know if you have any questions/problems.
…nement - Use finite difference gradient for error estimation - Include diagonal elements in 3^D subdivision - Update weight calculation method for volume conservation
- Fixed so that now works over any general axes - Vectorized it to make it faster
- Speeds up calculation
- Gradient didn't help with integration unfortunately - This quadrature error scheme looks at the contribution from the center point to its subdivision as the error
- Removed the hash-map storage, and now efficiently stores points and their previous function values
|
Hi Emily, Thanks for your work, bug fixes that you found, and the requested changes! I tried it out with the
I tried this out with some of your test-cases, and it improved the error measure. I would ignore the Hope this helps you with your final evaluation. |
|
Hi, Ali, |
-Modified the weighting method setting when creating the grid
Adds the AdaptiveUniformGrid wrapper class to provide recursive subdivision of a uniform grid.