[DERCBOT-1783] Admin: add evaluation sample management API by antoine-billiet-arkea-partnre · Pull Request #2001 · theopenconversationkit/tock

antoine-billiet-arkea-partnre · 2026-02-10T10:09:28Z

Add EvaluationSample and Evaluation models with all required fields
Add ActionRef, EvaluationReason, EvaluationsResult, Evaluator models
Implement EvaluationSampleDAO and EvaluationDAO interfaces
Implement MongoDB DAOs with proper indexing
Add EvaluationService with sample creation, evaluation, and status management
Add EvaluationVerticle with REST endpoints for CRUD operations
Add unit tests for service and integration tests for DAOs
Support pagination for action-refs with status filtering
Add evaluationsResult computation (total, evaluated, remaining, positiveCount, negativeCount)

Copilot

Pull request overview

This PR adds an evaluation sample management API for bot administrators. It introduces a comprehensive evaluation system allowing users to create evaluation samples from bot dialog actions, evaluate them (UP/DOWN with reasons), and manage their lifecycle (IN_PROGRESS/VALIDATED/CANCELLED).

Changes:

Adds data models for evaluations (EvaluationSample, Evaluation, ActionRef, Evaluator, EvaluationReason, etc.)
Implements MongoDB DAOs with proper indexing for persistence
Adds REST API endpoints via EvaluationVerticle for CRUD operations
Removes auto-generated Kotlin serializer/deserializer files (build artifacts)

Reviewed changes

Copilot reviewed 20 out of 159 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
bot/storage-mongo/target/generated-sources/kapt/compile/*.kt	Deleted auto-generated serialization files (build artifacts)
bot/engine/src/main/kotlin/admin/evaluation/*.kt	New evaluation domain models and DAO interfaces
bot/storage-mongo/src/main/kotlin/EvaluationMongoDAO.kt	MongoDB implementation for Evaluation DAO
bot/storage-mongo/src/main/kotlin/EvaluationSampleMongoDAO.kt	MongoDB implementation for EvaluationSample DAO
bot/storage-mongo/src/main/kotlin/Ioc.kt	IoC bindings for new DAOs
bot/admin/server/src/main/kotlin/verticle/EvaluationVerticle.kt	REST API endpoints for evaluation management
bot/admin/server/src/main/kotlin/BotAdminVerticle.kt	Integration of EvaluationVerticle
.idea/runConfigurations/BotAdmin.xml	IDE configuration update

Files not reviewed (1)

.idea/runConfigurations/BotAdmin.xml: Language not supported

vsct-jburet · 2026-02-12T15:09:18Z

.../target/generated-sources/kapt/compile/ai/tock/bot/admin/bot/BotApplicationConfiguration_.kt

The generated files are intentionally committed in order to track changes made by the generators

not blocking but if tou have 2s to commit them again ;)

assouktim

Thanks! There are still a few improvements to be made. I'll let you see my comments.

bot/admin/server/src/main/kotlin/verticle/EvaluationVerticle.kt

bot/admin/server/src/main/kotlin/service/EvaluationService.kt

bot/storage-mongo/src/main/kotlin/EvaluationMongoDAO.kt

- Add EvaluationSample and Evaluation models with all required fields - Add ActionRef, EvaluationReason, EvaluationsResult, Evaluator models - Implement EvaluationSampleDAO and EvaluationDAO interfaces - Implement MongoDB DAOs with proper indexing - Add EvaluationService with sample creation, evaluation, and status management - Add EvaluationVerticle with REST endpoints for CRUD operations - Add unit tests for service and integration tests for DAOs - Support pagination for action-refs with status filtering - Add evaluationsResult computation (total, evaluated, remaining, positiveCount, negativeCount)

…able filter, 422, cascade delete - DialogReportQuery: add random and evaluableActionsOnly params - UserTimelineMongoDAO: $sample, buildEvaluableActionsFilter - EvaluationService: flatMap, debug filter, 422 on no dialogs, evaluableActionsOnly - UnprocessableEntityException: HTTP 422 with code 4221, NO_DIALOG_FOUND - EvaluationSampleDAO: deleteByNamespaceAndBotId for cascade - BotAdminService: call cascade delete in deleteApplication - AbstractNamespaceRetriever: extract currentContextApp - ktlint: fix UnprocessableEntityException (no-empty-first-line-in-class-body) Co-authored-by: Cursor <cursoragent@cursor.com>

Generated files from KMongo/kapt for BotApplicationConfiguration and BotConfiguration. Intentionally committed to track changes made by the generators. Co-authored-by: Cursor <cursoragent@cursor.com>

- Remove duplicate import in UserTimelineMongoDAO.kt - Reorder imports per standard:import-ordering - Format deleteByNamespaceAndBotId signature in EvaluationSampleMongoDAO.kt Co-authored-by: Cursor <cursoragent@cursor.com>

- Replace wildcard imports with explicit imports in EvaluationService - Fix import ordering in BotAdminService - Fix spacing, indentation and blank lines in GenAIVerticle, AbstractNamespaceRetriever, EvaluationVerticle - Fix multiline expression in EvaluationServiceTest Co-authored-by: Cursor <cursoragent@cursor.com>

EvaluationSampleDTO is in model.evaluation, not evaluation package Co-authored-by: Cursor <cursoragent@cursor.com>

assouktim

All that's missing is the commit of the regenerated files.
Ok for changes, thanks!

Restore 132 KAPT-generated files accidentally removed in fdab228. Aligns with master (138 tracked files in bot/storage-mongo/target/). Co-authored-by: Cursor <cursoragent@cursor.com>

…, add TU - POST create sample: return 201 Created instead of 200 - DELETE sample: return 204 No Content without body - Rename ActionRefsQuery -> EvaluationDialogsQuery, ActionRefsResponse -> EvaluationDialogsResponse - Rename getActionRefs -> getEvaluationDialogs with KDoc comments - Add EvaluationModelTest for EvaluationDialogsQuery serialization - Add TU: findSampleById, getEvaluationDialogs throws, evaluate/changeStatus edge cases - Add TU: getEvaluationDialogs with missing dialogs (missingRefs) - ktlint fixes Made-with: Cursor

Made-with: Cursor

see above

antoine-billiet-arkea-partnre force-pushed the feat/DERCBOT-1783_list_evaluation_sets branch from b085a81 to 5c295f2 Compare February 10, 2026 13:35

vsct-jburet requested a review from Copilot February 12, 2026 13:11

Copilot started reviewing on behalf of vsct-jburet February 12, 2026 13:12 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

vsct-jburet self-requested a review February 12, 2026 15:03

vsct-jburet reviewed Feb 12, 2026

View reviewed changes

vsct-jburet approved these changes Feb 12, 2026

View reviewed changes

antoine-billiet-arkea-partnre assigned assouktim Feb 12, 2026

assouktim requested changes Feb 16, 2026

View reviewed changes

assouktim reviewed Feb 17, 2026

View reviewed changes

bot/storage-mongo/src/main/kotlin/EvaluationMongoDAO.kt Show resolved Hide resolved

antoine-billiet-arkea-partnre and others added 3 commits February 24, 2026 15:11

chore(bot): add generated kapt sources for tracking (PR feedback)

7674e42

Generated files from KMongo/kapt for BotApplicationConfiguration and BotConfiguration. Intentionally committed to track changes made by the generators. Co-authored-by: Cursor <cursoragent@cursor.com>

antoine-billiet-arkea-partnre force-pushed the feat/DERCBOT-1783_list_evaluation_sets branch from 5c295f2 to 7674e42 Compare February 24, 2026 14:14

antoine-billiet-arkea-partnre and others added 3 commits February 24, 2026 15:48

fix(storage-mongo): resolve ktlint violations for PIC

3a0d511

- Remove duplicate import in UserTimelineMongoDAO.kt - Reorder imports per standard:import-ordering - Format deleteByNamespaceAndBotId signature in EvaluationSampleMongoDAO.kt Co-authored-by: Cursor <cursoragent@cursor.com>

fix(admin): correct EvaluationSampleDTO import package

34ace5a

EvaluationSampleDTO is in model.evaluation, not evaluation package Co-authored-by: Cursor <cursoragent@cursor.com>

assouktim requested changes Feb 25, 2026

View reviewed changes

chore(bot): restore generated KAPT sources for storage-mongo

e04d8d7

Restore 132 KAPT-generated files accidentally removed in fdab228. Aligns with master (138 tracked files in bot/storage-mongo/target/). Co-authored-by: Cursor <cursoragent@cursor.com>

assouktim approved these changes Feb 25, 2026

View reviewed changes

assouktim marked this pull request as draft February 25, 2026 14:17

antoine-billiet-arkea-partnre added 3 commits February 27, 2026 16:31

test(storage-mongo): add empty dialogIds evaluation test

297cb5a

Made-with: Cursor

fix: change instanciation of dao in unittest

c66588e

see above

antoine-billiet-arkea-partnre requested a review from assouktim March 2, 2026 15:10

antoine-billiet-arkea-partnre marked this pull request as ready for review March 2, 2026 15:11

antoine-billiet-arkea-partnre marked this pull request as draft March 3, 2026 08:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DERCBOT-1783] Admin: add evaluation sample management API#2001

[DERCBOT-1783] Admin: add evaluation sample management API#2001
antoine-billiet-arkea-partnre wants to merge 10 commits intotheopenconversationkit:masterfrom
CreditMutuelArkea:feat/DERCBOT-1783_list_evaluation_sets

antoine-billiet-arkea-partnre commented Feb 10, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

vsct-jburet Feb 12, 2026

Uh oh!

vsct-jburet Feb 12, 2026

Uh oh!

assouktim left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

assouktim left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

antoine-billiet-arkea-partnre commented Feb 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

vsct-jburet Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

vsct-jburet Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

assouktim left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

assouktim left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants