soundwire: fix programing unattached BUSCLOCK_SCALE issue #5666
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we program bus clock scale index unconditionally. It is not necessary if the new index is the same as the current one. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
…eral The SDW_SCP_BUSCLOCK_SCALE register will be programed when the Peripheral is attached. We can and should skip programing the SDW_SCP_BUSCLOCK_SCALE register when the Peripheral is unattached. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
bardliao
requested review from
charleskeepax,
plbossart,
ranj063,
rfvirgil,
shumingfan,
simontrimmer and
ujfalusi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do need to set the same bus clock scale on all Peripherals to make sure all Peripherals are running on the same frequency. But we can skip the unattached Peripherals when programing params. Because the frequency will be set when the Peripheral is attached.