module_adapter: generic: Clean up and optimize mod_free_all()#10316
Merged
lgirdwood merged 1 commit intothesofproject:mainfrom Nov 3, 2025
Merged
module_adapter: generic: Clean up and optimize mod_free_all()#10316lgirdwood merged 1 commit intothesofproject:mainfrom
lgirdwood merged 1 commit intothesofproject:mainfrom
Conversation
Rewrite misleading copy-pasted comment and remove unnecessary container removals from res->res_list and res->cont_chunk_list. All the containers are anyway freed when the container chunks are freed and the list heads are reinitialized when mod_resource_init() is called. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
jsarha
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the mod_free_all() function by removing redundant list item deletions and updating a misleading comment. The optimization is based on the observation that all containers are freed when their container chunks are freed, making individual list item removals unnecessary.
Key changes:
- Replaced misleading comment about finding memory containers with accurate description of freeing container contents
- Removed unnecessary
list_item_del()calls from the res_list iteration - Removed entire iteration over free_cont_list as it only performed unnecessary list deletions
- Added explanatory comment documenting why container removal operations are not needed
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lgirdwood
approved these changes
Oct 22, 2025
lyakh
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite misleading copy-pasted comment and remove unnecessary container removals from res->res_list and res->cont_chunk_list. All the containers are anyway freed when the container chunks are freed and the list heads are reinitialized when mod_resource_init() is called.