Skip to content

audio: module-adapter: fix a print and a comment #10531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lyakh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

audio: module-adapter: fix a print and a comment #10531

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/audio/module_adapter/module_adapter.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,8 +210,7 @@ struct comp_dev *module_adapter_new_ext(const struct comp_driver *drv,
comp_cl_dbg(drv, "start");

if (!config) {
comp_cl_err(drv, "wrong input params! drv = %zx config = %zx",
(size_t)drv, (size_t)config);
comp_cl_err(drv, "NULL config! drv = %p", drv);
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using %p requires a void* argument; passing drv (const struct comp_driver*) can trigger -Wformat under -Werror builds. Cast drv to (const void*) (or (void*)) when logging it, or switch back to an integer format with an explicit cast.

Suggested change
comp_cl_err(drv, "NULL config! drv = %p", drv);
comp_cl_err(drv, "NULL config! drv = %p", (const void *)drv);

Copilot uses AI. Check for mistakes.
return NULL;
}
#if CONFIG_IPC_MAJOR_4
Expand Down Expand Up @@ -248,8 +247,7 @@ struct comp_dev *module_adapter_new_ext(const struct comp_driver *drv,
* NOTE: dst->ext_data points to stack variable and contains
* pointers to IPC payload mailbox, so its only valid in
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar: "its" should be "it's" (contraction for "it is") in this comment.

Suggested change
* pointers to IPC payload mailbox, so its only valid in
* pointers to IPC payload mailbox, so it's only valid in

Copilot uses AI. Check for mistakes.
* functions that called from this function. This why
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar: "This why" should be "This is why" in this comment.

Suggested change
* functions that called from this function. This why
* functions that called from this function. This is why

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar: "functions that called" should be "functions that are called" in this comment.

Suggested change
* functions that called from this function. This why
* functions that are called from this function. That is why

Copilot uses AI. Check for mistakes.
* the pointer is set NULL before the this function
* exits.
* the pointer is set NULL before this function exits.
*/
#if CONFIG_IPC_MAJOR_4
dst->ext_data = &ext_data;
Expand Down