audio: module-adapter: Fix SRC regression when ext_init dp_data present #10544
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
Fixes an SRC DP initialization regression when dp_data is present in the ext_init payload by adjusting how the module adapter decides between legacy vs. extended init handling.
Changes:
- Changes the legacy/extended init decision to hinge on whether
module_datais present in theext_initpayload. - Adds a clarifying comment about assuming the legacy API when module data is absent.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fix SRC DP regression when dp_data is present in the ext_init payload. The only situation where we can assume that there is no module specific init after the ext_init payload is when it was offered as part of ext_init payload. Completes fix abf1aa9 ("audio: module-adapter: fix SRC DP regression") Fixes: d263649 ("module: Add support for module-specific init data") Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
jsarha
force-pushed
the
assume_legacy_mod_data_if_no_ext_init_mod_data
branch
from
1d0803c to
4841dc6
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix SRC DP regression when dp_data is present in the ext_init payload.
The only situation where we can assume that there is no module specific init after the ext_init payload is when it was offered as part of ext_init payload.
Completes fix abf1aa9 ("audio: module-adapter: fix SRC DP regression")
Fixes: d263649 ("module: Add support for module-specific init data")
This fix is required for thesofproject/linux#5537 to work as it shoud.