module_adapter: dp: Improve module adapter creation function

[softwarecki]

• Add checking of the return value from pipeline_comp_dp_task_init() to ensure the dp thread is created successfully. This prevents execution from continuing with an invalid task.
• Update scheduler_dp_task_init() to assign the output task pointer only on success. The function frees the allocated task structure on failure, so returning a non-null task could lead to a double free or use after free.
• Move mod field initialization in module_adapter_new_ext() to occur before creating the dp thread. This prevents the thread from use uninitialized fields.

[Copilot]

Pull request overview

This PR improves error handling and initialization order in the module adapter creation flow for data processing tasks. The changes ensure that task creation failures are properly detected and handled, prevent potential use-after-free issues, and guarantee that module fields are initialized before the DP thread can access them.

Changes:

• Add error checking for DP task initialization to catch creation failures
• Fix task pointer assignment to only occur on successful initialization
• Reorder module field initialization to happen before DP thread creation

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/schedule/zephyr_dp_schedule_thread.c	Modified scheduler_dp_task_init() to defer task pointer assignment until after successful thread creation
src/audio/module_adapter/module_adapter.c	Added error handling for DP task creation and moved module field initialization before thread creation

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[lyakh]

I suppose this isn't breaking anything and in fact does seem logical, but for the understanding: is this use of uninitialised data really happening? This is called in IPC context. The DP thread suspends immediately when started - I suppose in the "thread" variant too? The thread shouldn't be woken up before this IPC processing completes?

[softwarecki]

Yes, the dp thread creation function uses user_ctx. If we don't assign this value first, a kernel dp thread will be created instead of a userspace thread.