Conversation
I am only testing the PR in Zephyr. Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
Enabling CONFIG_LOG_CORE_ID_PREFIX for all ACE platforms. Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
There was a problem hiding this comment.
Pull request overview
This is a CI-only pull request for testing Zephyr changes, as indicated by the "[CIONLY]" prefix in the title. The PR updates the Zephyr revision to reference a pull request and enables core ID prefixes in logging for Intel ADSP ACE platforms.
Changes:
- Updates Zephyr revision to pull/104399/head for testing purposes
- Enables CONFIG_LOG_CORE_ID_PREFIX for all Intel ADSP ACE platform boards (ACE15, ACE20, ACE30, ACE40 variants)
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| west.yml | Changes Zephyr revision from a commit SHA to a PR reference for CI testing |
| app/boards/intel_adsp_ace40_nvls.conf | Adds CONFIG_LOG_CORE_ID_PREFIX to enable core ID logging |
| app/boards/intel_adsp_ace40_nvl.conf | Adds CONFIG_LOG_CORE_ID_PREFIX to enable core ID logging |
| app/boards/intel_adsp_ace30_wcl.conf | Adds CONFIG_LOG_CORE_ID_PREFIX to enable core ID logging |
| app/boards/intel_adsp_ace30_ptl.conf | Adds CONFIG_LOG_CORE_ID_PREFIX to enable core ID logging |
| app/boards/intel_adsp_ace20_lnl.conf | Adds CONFIG_LOG_CORE_ID_PREFIX to enable core ID logging |
| app/boards/intel_adsp_ace15_mtpm.conf | Adds CONFIG_LOG_CORE_ID_PREFIX to enable core ID logging |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: zephyr | ||
| repo-path: zephyr | ||
| revision: b246d3f3f987f5ddfa6530bea2082c09ce1f00d8 | ||
| revision: pull/104399/head |
There was a problem hiding this comment.
Using a pull request reference instead of a specific commit SHA in the Zephyr revision is not suitable for production code. The pull/104399/head reference is volatile and may change as the PR is updated, leading to non-reproducible builds. This appears to be a testing/CI configuration that should not be merged to the main branch. Consider using a specific commit SHA once the Zephyr PR is merged.
| revision: pull/104399/head | |
| revision: 4e1d3ba61abd3e3a03f5ec7d8d33be705c5ce8a6 |
No description provided.