lib-manager: fix lib id packing

[wjablon1]

I found this issue in lib_manager during testing. For now, I want to apply a simple fix to unblock my pending work because I don’t know yet how to remove this confusion from the lib_manager function interface that caused the mistake. On one hand the signature of lib_manager_get_library_manifest says clearly that the function takes module ID as a parameter (which is LIB_ID << 12 | MODULE_INDEX). On the other hand, I can understand how someone would expect a different behavior just by looking at the function name itself. We can change the argument type, but some functions in this file also take module_id encoded this way. Maybe we should group some functions related to a module in a separate C file?

[softwarecki]

My intent was to have all functions accept a single module_id parameter. They extract whichever fields they need. I considered this clearer than splitting it into lib_id, mod_id, and mod_inst. The downside, as visible here, is that an incorrect value can be passed by mistake. Good catch!

[wjablon1]

@softwarecki It's hard for me to tell whether the interface itself is a problem. I made the same mistake in my pending changes only because I did copy-paste of the incorrect code. Maybe the situation would be different if I wrote my code from scratch. But the code looked fine at first glace.