vregion: replace error messages with warnings#10683
Merged
kv2019i merged 1 commit intothesofproject:mainfrom Apr 8, 2026
Merged
vregion: replace error messages with warnings#10683kv2019i merged 1 commit intothesofproject:mainfrom
kv2019i merged 1 commit intothesofproject:mainfrom
Conversation
Error messages make CI fail. Replace them with warnings for an immediate fix but a better solution is needed eventually. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
lyakh
requested review from
abonislawski,
dbaluta,
iuliana-prodan and
kv2019i
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces the severity of two allocation-failure log messages in Zephyr’s vregion allocator, changing them from errors to warnings to avoid CI failures triggered by error logs.
Changes:
- Switched
interim_alloc()allocation-failure logging fromLOG_ERRtoLOG_WRN(and removed the"error:"prefix). - Switched
lifetime_alloc()out-of-space logging fromLOG_ERRtoLOG_WRN(and removed the"error:"prefix).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
@lrudyX timeout - need to rerun? or is it still working? |
kv2019i
approved these changes
Apr 8, 2026
Collaborator
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
I'd prefer to change the test case. This is a bit silly we can't have negative tests (= errors) in boot tests. Oh well...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error messages make CI fail. Replace them with warnings for an immediate fix but a better solution is needed eventually.